]> git.itanic.dy.fi Git - linux-stable/commit
NFSv4: nfs4_stateid_is_current should return 'true' for an invalid stateid
authorTrond Myklebust <trond.myklebust@primarydata.com>
Wed, 5 Mar 2014 13:44:23 +0000 (08:44 -0500)
committerJiri Slaby <jslaby@suse.cz>
Sat, 22 Mar 2014 21:01:58 +0000 (22:01 +0100)
commitff3918ebdc2d35c0e57b6aa8c32098f40ab83bd0
treea2f02bc38616e17764933a299275b32e0050f667
parent793c6f9509f87e2918a551e88605d833cacc9546
NFSv4: nfs4_stateid_is_current should return 'true' for an invalid stateid

commit e1253be0ece1a95a02c7f5843194877471af8179 upstream.

When nfs4_set_rw_stateid() can fails by returning EIO to indicate that
the stateid is completely invalid, then it makes no sense to have it
trigger a retry of the READ or WRITE operation. Instead, we should just
have it fall through and attempt a recovery.

This fixes an infinite loop in which the client keeps replaying the same
bad stateid back to the server.

Reported-by: Andy Adamson <andros@netapp.com>
Link: http://lkml.kernel.org/r/1393954269-3974-1-git-send-email-andros@netapp.com
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
fs/nfs/nfs4proc.c