]> git.itanic.dy.fi Git - linux-stable/commit
leds: trigger: ledtrig-cpu:: Fix 'output may be truncated' issue for 'cpu'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 23 Sep 2023 07:15:38 +0000 (09:15 +0200)
committerLee Jones <lee@kernel.org>
Wed, 1 Nov 2023 11:28:51 +0000 (11:28 +0000)
commitff50f53276131a3059e8307d11293af388ed2bcd
tree76c8d34a0388d9464dd7e8868eea36051d73dbbe
parent76fe464c8e64e71b2e4af11edeef0e5d85eeb6aa
leds: trigger: ledtrig-cpu:: Fix 'output may be truncated' issue for 'cpu'

In order to teach the compiler that 'trig->name' will never be truncated,
we need to tell it that 'cpu' is not negative.

When building with W=1, this fixes the following warnings:

  drivers/leds/trigger/ledtrig-cpu.c: In function ‘ledtrig_cpu_init’:
  drivers/leds/trigger/ledtrig-cpu.c:155:56: error: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size 5 [-Werror=format-truncation=]
    155 |                 snprintf(trig->name, MAX_NAME_LEN, "cpu%d", cpu);
        |                                                        ^~
  drivers/leds/trigger/ledtrig-cpu.c:155:52: note: directive argument in the range [-2147483648, 7]
    155 |                 snprintf(trig->name, MAX_NAME_LEN, "cpu%d", cpu);
        |                                                    ^~~~~~~
  drivers/leds/trigger/ledtrig-cpu.c:155:17: note: ‘snprintf’ output between 5 and 15 bytes into a destination of size 8
    155 |                 snprintf(trig->name, MAX_NAME_LEN, "cpu%d", cpu);
        |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 8f88731d052d ("led-triggers: create a trigger for CPU activity")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/3f4be7a99933cf8566e630da54f6ab913caac432.1695453322.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/trigger/ledtrig-cpu.c