]> git.itanic.dy.fi Git - linux-stable/commit
arm64: dts: imx8qm-ss-dma: fix can lpcg indices
authorFrank Li <Frank.Li@nxp.com>
Mon, 1 Apr 2024 22:25:09 +0000 (18:25 -0400)
committerShawn Guo <shawnguo@kernel.org>
Wed, 3 Apr 2024 12:44:54 +0000 (20:44 +0800)
commit00b436182138310bb8d362b912b12a9df8f72ca3
tree636c4d1f3c2c943610df41385e7a08bd8b0bd59c
parent0893392334b5dffdf616a53679c6a2942c46391b
arm64: dts: imx8qm-ss-dma: fix can lpcg indices

can1_lpcg: clock-controller@5ace0000 {
...     Col1   Col2
clocks = <&clk IMX_SC_R_CAN_1 IMX_SC_PM_CLK_PER>,//  0       0
 <&dma_ipg_clk>,  //  1       4
 <&dma_ipg_clk>;  //  2       5
clock-indices = <IMX_LPCG_CLK_0>,
<IMX_LPCG_CLK_4>,
<IMX_LPCG_CLK_5>;
};

Col1: index, which existing dts try to get.
Col2: actual index in lpcg driver

&flexcan2 {
clocks = <&can1_lpcg 1>, <&can1_lpcg 0>;
     ^^      ^^
Should be:
clocks = <&can1_lpcg IMX_LPCG_CLK_4>, <&can1_lpcg IMX_LPCG_CLK_0>;
};

Arg0 is divided by 4 in lpcg driver. So flexcan get IMX_SC_PM_CLK_PER by
<&can1_lpcg 1> and <&can1_lpcg 0>. Although function work, code logic is
wrong. Fix it by using correct clock indices.

Cc: stable@vger.kernel.org
Fixes: be85831de020 ("arm64: dts: imx8qm: add can node in devicetree")
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
arch/arm64/boot/dts/freescale/imx8qm-ss-dma.dtsi