]> git.itanic.dy.fi Git - linux-stable/commit
usb: dwc3: gadget: Avoid duplicate requests to enable Run/Stop
authorWesley Cheng <quic_wcheng@quicinc.com>
Thu, 28 Jul 2022 02:06:47 +0000 (19:06 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Aug 2022 19:10:44 +0000 (21:10 +0200)
commit040f2dbd2010c43f33ad27249e6dac48456f4d99
tree8f4af458012cd5a88f855bb334ecf500d3e15b25
parentbad0d1d726ace2db9e0f39c62b173bc7cc43dd6a
usb: dwc3: gadget: Avoid duplicate requests to enable Run/Stop

Relocate the pullups_connected check until after it is ensured that there
are no runtime PM transitions.  If another context triggered the DWC3
core's runtime resume, it may have already enabled the Run/Stop.  Do not
re-run the entire pullup sequence again, as it may issue a core soft
reset while Run/Stop is already set.

This patch depends on
  commit 69e131d1ac4e ("usb: dwc3: gadget: Prevent repeat pullup()")

Fixes: 77adb8bdf422 ("usb: dwc3: gadget: Allow runtime suspend if UDC unbinded")
Cc: stable <stable@kernel.org>
Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Link: https://lore.kernel.org/r/20220728020647.9377-1-quic_wcheng@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/gadget.c