]> git.itanic.dy.fi Git - linux-stable/commit
media: netup_unidvb: fix use-after-free at del_timer()
authorDuoming Zhou <duoming@zju.edu.cn>
Wed, 8 Mar 2023 12:55:14 +0000 (12:55 +0000)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Sun, 14 May 2023 05:28:57 +0000 (06:28 +0100)
commit0f5bb36bf9b39a2a96e730bf4455095b50713f63
treef820beaf00c16484ba988bd25e3fb7686bb4dda7
parent7efb10d8dc70ea3000cc70dca53407c52488acd1
media: netup_unidvb: fix use-after-free at del_timer()

When Universal DVB card is detaching, netup_unidvb_dma_fini()
uses del_timer() to stop dma->timeout timer. But when timer
handler netup_unidvb_dma_timeout() is running, del_timer()
could not stop it. As a result, the use-after-free bug could
happen. The process is shown below:

    (cleanup routine)          |        (timer routine)
                               | mod_timer(&dev->tx_sim_timer, ..)
netup_unidvb_finidev()         | (wait a time)
  netup_unidvb_dma_fini()      | netup_unidvb_dma_timeout()
    del_timer(&dma->timeout);  |
                               |   ndev->pci_dev->dev //USE

Fix by changing del_timer() to del_timer_sync().

Link: https://lore.kernel.org/linux-media/20230308125514.4208-1-duoming@zju.edu.cn
Fixes: 52b1eaf4c59a ("[media] netup_unidvb: NetUP Universal DVB-S/S2/T/T2/C PCI-E card driver")
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/pci/netup_unidvb/netup_unidvb_core.c