]> git.itanic.dy.fi Git - linux-stable/commit
firmware: arm_ffa: Set reserved/MBZ fields to zero in the memory descriptors
authorSudeep Holla <sudeep.holla@arm.com>
Wed, 3 May 2023 13:12:52 +0000 (14:12 +0100)
committerSudeep Holla <sudeep.holla@arm.com>
Mon, 8 May 2023 19:40:46 +0000 (20:40 +0100)
commit111a833dc5cbef3d05b2a796a7e23cb7f6ff2192
tree6acc96f8f5e34b7e97f74848ac3bfe793371dd1e
parent19b8766459c41c6f318f8a548cc1c66dffd18363
firmware: arm_ffa: Set reserved/MBZ fields to zero in the memory descriptors

The transmit buffers allocated by the driver can be used to transmit data
by any messages/commands needing the buffer. However, it is not guaranteed
to have been zero-ed before every new transmission and hence it will just
contain residual value from the previous transmission. There are several
reserved fields in the memory descriptors that must be zero(MBZ). The
receiver can reject the transmission if any such MBZ fields are non-zero.

While we can set the whole page to zero, it is not optimal as most of the
fields get initialised to the value required for the current transmission.

So, just set the reserved/MBZ fields to zero in the memory descriptors
explicitly to honour the requirement and keep the receiver happy.

Fixes: cc2195fe536c ("firmware: arm_ffa: Add support for MEM_* interfaces")
Reported-by: Marc Bonnici <marc.bonnici@arm.com>
Link: https://lore.kernel.org/r/20230503131252.12585-1-sudeep.holla@arm.com
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
drivers/firmware/arm_ffa/driver.c