]> git.itanic.dy.fi Git - linux-stable/commit
gpio: tqmx86: fix uninitialized variable girq
authorDongliang Mu <mudongliangabcd@gmail.com>
Mon, 19 Sep 2022 03:12:49 +0000 (11:12 +0800)
committerBartosz Golaszewski <brgl@bgdev.pl>
Wed, 21 Sep 2022 07:31:22 +0000 (09:31 +0200)
commit21a9acc162457402c74c5c1e16471fda6eb090c0
tree5d1ffb84ed8db117d2d746d9da14ecb37c036623
parentab637d48363d7b8ee67ae089808a8bc6051d53c4
gpio: tqmx86: fix uninitialized variable girq

The commit 924610607f19 ("gpio: tpmx86: Move PM device over to
irq domain") adds a dereference of girq that may be uninitialized.

Fix this by moving irq_domain_set_pm_device into if true branch
as suggested by Marc Zyngier.

Fixes: 924610607f19 ("gpio: tpmx86: Move PM device over to irq domain")
Suggested-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Acked-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpio-tqmx86.c