]> git.itanic.dy.fi Git - linux-stable/commit
KVM: PPC: Tick accounting should defer vtime accounting 'til after IRQ handling
authorLaurent Vivier <lvivier@redhat.com>
Wed, 27 Oct 2021 14:21:50 +0000 (00:21 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 28 Oct 2021 11:27:48 +0000 (22:27 +1100)
commit235cee162459d96153d63651ce7ff51752528c96
tree8c6bc541a7d4d28a1fd5c87dfa34d2196ba77dba
parent322fda0405fecaaa540b0fa90393830aaadaf420
KVM: PPC: Tick accounting should defer vtime accounting 'til after IRQ handling

Commit 112665286d08 ("KVM: PPC: Book3S HV: Context tracking exit guest
context before enabling irqs") moved guest_exit() into the interrupt
protected area to avoid wrong context warning (or worse). The problem is
that tick-based time accounting has not yet been updated at this point
(because it depends on the timer interrupt firing), so the guest time
gets incorrectly accounted to system time.

To fix the problem, follow the x86 fix in commit 160457140187 ("Defer
vtime accounting 'til after IRQ handling"), and allow host IRQs to run
before accounting the guest exit time.

In the case vtime accounting is enabled, this is not required because TB
is used directly for accounting.

Before this patch, with CONFIG_TICK_CPU_ACCOUNTING=y in the host and a
guest running a kernel compile, the 'guest' fields of /proc/stat are
stuck at zero. With the patch they can be observed increasing roughly as
expected.

Fixes: e233d54d4d97 ("KVM: booke: use __kvm_guest_exit")
Fixes: 112665286d08 ("KVM: PPC: Book3S HV: Context tracking exit guest context before enabling irqs")
Cc: stable@vger.kernel.org # 5.12+
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
[np: only required for tick accounting, add Book3E fix, tweak changelog]
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20211027142150.3711582-1-npiggin@gmail.com
arch/powerpc/kvm/book3s_hv.c
arch/powerpc/kvm/booke.c