]> git.itanic.dy.fi Git - linux-stable/commit
tcp: fix wrong checksum calculation on MTU probing
authorDouglas Caetano dos Santos <douglascs@taghos.com.br>
Thu, 22 Sep 2016 18:52:04 +0000 (15:52 -0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 23 Sep 2016 11:55:02 +0000 (07:55 -0400)
commit2fe664f1fcf7c4da6891f95708a7a56d3c024354
tree44bf1c6e889204e43ae18c85be64e0713d451782
parentf44ace4d06aab8210d29c731f70b657a7524198b
tcp: fix wrong checksum calculation on MTU probing

With TCP MTU probing enabled and offload TX checksumming disabled,
tcp_mtu_probe() calculated the wrong checksum when a fragment being copied
into the probe's SKB had an odd length. This was caused by the direct use
of skb_copy_and_csum_bits() to calculate the checksum, as it pads the
fragment being copied, if needed. When this fragment was not the last, a
subsequent call used the previous checksum without considering this
padding.

The effect was a stale connection in one way, as even retransmissions
wouldn't solve the problem, because the checksum was never recalculated for
the full SKB length.

Signed-off-by: Douglas Caetano dos Santos <douglascs@taghos.com.br>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_output.c