]> git.itanic.dy.fi Git - linux-stable/commit
platform/x86/amd: pmc: Utilize SMN index 0 for driver probe
authorShyam Sundar S K <Shyam-sundar.S-k@amd.com>
Sun, 9 Apr 2023 18:53:45 +0000 (00:23 +0530)
committerHans de Goede <hdegoede@redhat.com>
Tue, 11 Apr 2023 08:37:27 +0000 (10:37 +0200)
commit310e782a99c7f16fb533a45d8f9c16defefa5aab
tree73322c012a7706ae755a038a0cc23a5de34eddcc
parent9217bd1d7699f34a01b26ba14ff38c1714ce1185
platform/x86/amd: pmc: Utilize SMN index 0 for driver probe

The current SMN index used for the driver probe seems to be meant
for the BIOS pair and there are potential concurrency problems that can
occur with an inopportune SMI.

It is been advised to use SMN_INDEX_0 instead of SMN_INDEX_2, which is
what amd_nb.c provides and this function has protections to ensure that
only one caller can use it at a time.

Fixes: 156ec4731cb2 ("platform/x86: amd-pmc: Add AMD platform support for S2Idle")
Co-developed-by: Sanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://lore.kernel.org/r/20230409185348.556161-6-Shyam-sundar.S-k@amd.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/amd/Kconfig
drivers/platform/x86/amd/pmc.c