]> git.itanic.dy.fi Git - linux-stable/commit
net: usb: Fix memory leak on Tx data path
authorHemant Kumar <hemantk@codeaurora.org>
Thu, 25 Oct 2012 18:17:54 +0000 (18:17 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Oct 2012 07:43:15 +0000 (03:43 -0400)
commit39707c2a3ba5011038b363f84d37c8a98d2d9db1
treef1d0eea410e1da545fcc7230386810ed7969787b
parentbfc0d8c3de31a51e671e2c1564fd194fa6b00179
net: usb: Fix memory leak on Tx data path

Driver anchors the tx urbs and defers the urb submission if
a transmit request comes when the interface is suspended.
Anchoring urb increments the urb reference count. These
deferred urbs are later accessed by calling usb_get_from_anchor()
for submission during interface resume. usb_get_from_anchor()
unanchors the urb but urb reference count remains same.
This causes the urb reference count to remain non-zero
after usb_free_urb() gets called and urb never gets freed.
Hence call usb_put_urb() after anchoring the urb to properly
balance the reference count for these deferred urbs. Also,
unanchor these deferred urbs during disconnect, to free them
up.

Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
Acked-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/usbnet.c