]> git.itanic.dy.fi Git - linux-stable/commit
swiotlb: avoid potential left shift overflow
authorChao Gao <chao.gao@intel.com>
Fri, 19 Aug 2022 08:45:37 +0000 (16:45 +0800)
committerChristoph Hellwig <hch@lst.de>
Wed, 7 Sep 2022 08:38:16 +0000 (10:38 +0200)
commit3f0461613ebcdc8c4073e235053d06d5aa58750f
treefb2bfd91fbf9fc1b9a55ddbdcce925c17a14a7df
parent2995b8002cefc7b0b00b8f9a0ce36601a8c390c0
swiotlb: avoid potential left shift overflow

The second operand passed to slot_addr() is declared as int or unsigned int
in all call sites. The left-shift to get the offset of a slot can overflow
if swiotlb size is larger than 4G.

Convert the macro to an inline function and declare the second argument as
phys_addr_t to avoid the potential overflow.

Fixes: 26a7e094783d ("swiotlb: refactor swiotlb_tbl_map_single")
Signed-off-by: Chao Gao <chao.gao@intel.com>
Reviewed-by: Dongli Zhang <dongli.zhang@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
kernel/dma/swiotlb.c