]> git.itanic.dy.fi Git - linux-stable/commit
cifs: remove useless parameter 'is_fsctl' from SMB2_ioctl()
authorEnzo Matsumiya <ematsumiya@suse.de>
Wed, 17 Aug 2022 19:08:34 +0000 (16:08 -0300)
committerSteve French <stfrench@microsoft.com>
Thu, 18 Aug 2022 04:30:49 +0000 (23:30 -0500)
commit400d0ad63b190895e29f43bc75b1260111d3fd34
treeeea19d02d6d80a3bb557d31c4253feac456c81f6
parent68ed14496b032b0c9ef21b38ee45c6c8f3a18ff1
cifs: remove useless parameter 'is_fsctl' from SMB2_ioctl()

SMB2_ioctl() is always called with is_fsctl = true, so doesn't make any
sense to have it at all.

Thus, always set SMB2_0_IOCTL_IS_FSCTL flag on the request.

Also, as per MS-SMB2 3.3.5.15 "Receiving an SMB2 IOCTL Request", servers
must fail the request if the request flags is zero anyway.

Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
Reviewed-by: Tom Talpey <tom@talpey.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/smb2file.c
fs/cifs/smb2ops.c
fs/cifs/smb2pdu.c
fs/cifs/smb2proto.h