]> git.itanic.dy.fi Git - linux-stable/commit
ksmbd: fix Null pointer dereferences in ksmbd_update_fstate()
authorNamjae Jeon <linkinjeon@kernel.org>
Wed, 11 Oct 2023 14:29:49 +0000 (23:29 +0900)
committerSteve French <stfrench@microsoft.com>
Fri, 13 Oct 2023 03:44:09 +0000 (22:44 -0500)
commit414849040fcf11d45025b8ae26c9fd91da1465da
tree83c81166e6af582453646313edeeac0e1b07f3da
parentbe0f89d4419dc5413a1cf06db3671c9949be0d52
ksmbd: fix Null pointer dereferences in ksmbd_update_fstate()

Coverity Scan report the following one. This report is a false alarm.
Because fp is never NULL when rc is zero. This patch add null check for fp
in ksmbd_update_fstate to make alarm silence.

*** CID 1568583:  Null pointer dereferences  (FORWARD_NULL)
/fs/smb/server/smb2pdu.c: 3408 in smb2_open()
3402                    path_put(&path);
3403                    path_put(&parent_path);
3404            }
3405            ksmbd_revert_fsids(work);
3406     err_out1:
3407            if (!rc) {
>>>     CID 1568583:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "fp" to "ksmbd_update_fstate", which dereferences it.
3408                    ksmbd_update_fstate(&work->sess->file_table, fp, FP_INITED);
3409                    rc = ksmbd_iov_pin_rsp(work, (void *)rsp, iov_len);
3410            }
3411            if (rc) {
3412                    if (rc == -EINVAL)
3413                            rsp->hdr.Status = STATUS_INVALID_PARAMETER;

Fixes: e2b76ab8b5c9 ("ksmbd: add support for read compound")
Reported-by: Coverity Scan <scan-admin@coverity.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/vfs_cache.c