]> git.itanic.dy.fi Git - linux-stable/commit
power: supply: bq27xxx: Fix I2C IRQ race on remove
authorHans de Goede <hdegoede@redhat.com>
Sat, 15 Apr 2023 18:23:33 +0000 (20:23 +0200)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Mon, 8 May 2023 13:29:11 +0000 (15:29 +0200)
commit444ff00734f3878cd54ddd1ed5e2e6dbea9326d5
tree2e563a29a4770d8eddaaa8bde706e9f57b693c30
parent5c34c0aef185dcd10881847b9ebf20046aa77cb4
power: supply: bq27xxx: Fix I2C IRQ race on remove

devm_request_threaded_irq() requested IRQs are only free-ed after
the driver's remove function has ran. So the IRQ could trigger and
call bq27xxx_battery_update() after bq27xxx_battery_teardown() has
already run.

Switch to explicitly free-ing the IRQ in bq27xxx_battery_i2c_remove()
to fix this.

Fixes: 8807feb91b76 ("power: bq27xxx_battery: Add interrupt handling support")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/bq27xxx_battery_i2c.c