]> git.itanic.dy.fi Git - linux-stable/commit
Revert "tcp: change pingpong threshold to 3"
authorWei Wang <weiwan@google.com>
Thu, 21 Jul 2022 20:44:04 +0000 (20:44 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 22 Jul 2022 22:09:10 +0000 (15:09 -0700)
commit4d8f24eeedc58d5f87b650ddda73c16e8ba56559
tree1abb5cdb4189b78d65eda21b514448946d3bc54c
parent8ee18e2a9e7b0e97730549f58dd618433c15811b
Revert "tcp: change pingpong threshold to 3"

This reverts commit 4a41f453bedfd5e9cd040bad509d9da49feb3e2c.

This to-be-reverted commit was meant to apply a stricter rule for the
stack to enter pingpong mode. However, the condition used to check for
interactive session "before(tp->lsndtime, icsk->icsk_ack.lrcvtime)" is
jiffy based and might be too coarse, which delays the stack entering
pingpong mode.
We revert this patch so that we no longer use the above condition to
determine interactive session, and also reduce pingpong threshold to 1.

Fixes: 4a41f453bedf ("tcp: change pingpong threshold to 3")
Reported-by: LemmyHuang <hlm3280@163.com>
Suggested-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Wei Wang <weiwan@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220721204404.388396-1-weiwan@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/inet_connection_sock.h
net/ipv4/tcp_output.c