]> git.itanic.dy.fi Git - linux-stable/commit
scsi: storvsc: Don't pass unused PFNs to Hyper-V host
authorMichael Kelley <mikelley@microsoft.com>
Mon, 15 May 2023 17:20:41 +0000 (10:20 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 17 May 2023 01:50:53 +0000 (21:50 -0400)
commit4e81a6cba517cb33584308a331f14f5e3fec369b
treed9d368a0924356e5ee29dddfeb5e3602dda18769
parent72a81bb0b6fc9b759ac0fdaca3ec5884a8b2f304
scsi: storvsc: Don't pass unused PFNs to Hyper-V host

In a SCSI request, storvsc pre-allocates space for up to
MAX_PAGE_BUFFER_COUNT physical frame numbers to be passed to Hyper-V.  If
the size of the I/O request requires more PFNs, a separate memory area of
exactly the correct size is dynamically allocated.

But when the pre-allocated area is used, current code always passes
MAX_PAGE_BUFFER_COUNT PFNs to Hyper-V, even if fewer are needed.  While
this doesn't break anything because the additional PFNs are always zero,
more bytes than necessary are copied into the VMBus channel ring buffer.
This takes CPU cycles and wastes space in the ring buffer. For a typical 4
Kbyte I/O that requires only a single PFN, 248 unnecessary bytes are
copied.

Fix this by setting the payload_sz based on the actual number of PFNs
required, not the size of the pre-allocated space.

Reported-by: John Starks <jostarks@microsoft.com>
Fixes: 8f43710543ef ("scsi: storvsc: Support PAGE_SIZE larger than 4K")
Signed-off-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/1684171241-16209-1-git-send-email-mikelley@microsoft.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/storvsc_drv.c