]> git.itanic.dy.fi Git - linux-stable/commit
cgroup: Fix threadgroup_rwsem <-> cpus_read_lock() deadlock
authorTejun Heo <tj@kernel.org>
Mon, 15 Aug 2022 23:27:38 +0000 (13:27 -1000)
committerTejun Heo <tj@kernel.org>
Wed, 17 Aug 2022 17:36:05 +0000 (07:36 -1000)
commit4f7e7236435ca0abe005c674ebd6892c6e83aeb3
tree35e9a5ce25341e6348141027edc1b4bfa141802c
parentd7ae5818c3fa3007dee13f9d99832e7f26b8bc44
cgroup: Fix threadgroup_rwsem <-> cpus_read_lock() deadlock

Bringing up a CPU may involve creating and destroying tasks which requires
read-locking threadgroup_rwsem, so threadgroup_rwsem nests inside
cpus_read_lock(). However, cpuset's ->attach(), which may be called with
thredagroup_rwsem write-locked, also wants to disable CPU hotplug and
acquires cpus_read_lock(), leading to a deadlock.

Fix it by guaranteeing that ->attach() is always called with CPU hotplug
disabled and removing cpus_read_lock() call from cpuset_attach().

Signed-off-by: Tejun Heo <tj@kernel.org>
Reviewed-and-tested-by: Imran Khan <imran.f.khan@oracle.com>
Reported-and-tested-by: Xuewen Yan <xuewen.yan@unisoc.com>
Fixes: 05c7b7a92cc8 ("cgroup/cpuset: Fix a race between cpuset_attach() and cpu hotplug")
Cc: stable@vger.kernel.org # v5.17+
kernel/cgroup/cgroup.c
kernel/cgroup/cpuset.c