]> git.itanic.dy.fi Git - linux-stable/commit
virtio_net: Fix error unwinding of XDP initialization
authorFeng Liu <feliu@nvidia.com>
Fri, 12 May 2023 15:18:12 +0000 (11:18 -0400)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 May 2023 07:46:48 +0000 (08:46 +0100)
commit5306623a9826aa7d63b32c6a3803c798a765474d
tree895b87217468e6fbe5151d7523402ce3fdcb3364
parent6ead9c98cafcbc6992cf35f0ca393df2c03e3316
virtio_net: Fix error unwinding of XDP initialization

When initializing XDP in virtnet_open(), some rq xdp initialization
may hit an error causing net device open failed. However, previous
rqs have already initialized XDP and enabled NAPI, which is not the
expected behavior. Need to roll back the previous rq initialization
to avoid leaks in error unwinding of init code.

Also extract helper functions of disable and enable queue pairs.
Use newly introduced disable helper function in error unwinding and
virtnet_close. Use enable helper function in virtnet_open.

Fixes: 754b8a21a96d ("virtio_net: setup xdp_rxq_info")
Signed-off-by: Feng Liu <feliu@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: William Tu <witu@nvidia.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/virtio_net.c