]> git.itanic.dy.fi Git - linux-stable/commit
USB: devio: Prevent integer overflow in proc_do_submiturb()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 22 Sep 2017 20:43:25 +0000 (23:43 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Sep 2017 08:57:13 +0000 (10:57 +0200)
commit57999d1107c1e60c2ca7088f2ac0f819e2f554b3
tree6081b8b694eeae7c08ea2cc082c9966517cdb838
parent1fbbb78f25d1291274f320462bf6908906f538db
USB: devio: Prevent integer overflow in proc_do_submiturb()

There used to be an integer overflow check in proc_do_submiturb() but
we removed it.  It turns out that it's still required.  The
uurb->buffer_length variable is a signed integer and it's controlled by
the user.  It can lead to an integer overflow when we do:

num_sgs = DIV_ROUND_UP(uurb->buffer_length, USB_SG_SIZE);

If we strip away the macro then that line looks like this:

num_sgs = (uurb->buffer_length + USB_SG_SIZE - 1) / USB_SG_SIZE;
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
It's the first addition which can overflow.

Fixes: 1129d270cbfb ("USB: Increase usbfs transfer limit")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/devio.c