]> git.itanic.dy.fi Git - linux-stable/commit
extcon: Modify extcon device to be created after driver data is set
authorbumwoo lee <bw365.lee@samsung.com>
Wed, 27 Apr 2022 03:00:05 +0000 (12:00 +0900)
committerChanwoo Choi <cw00.choi@samsung.com>
Fri, 13 May 2022 08:03:41 +0000 (17:03 +0900)
commit5dcc2afe716d69f5112ce035cb14f007461ff189
tree0323bc2e8c437f68772be69377622546ddf1d40f
parent5faf7cbaff459f885f09eed1e685a3cf9a19c78e
extcon: Modify extcon device to be created after driver data is set

Currently, someone can invoke the sysfs such as state_show()
intermittently before dev_set_drvdata() is done.
And it can be a cause of kernel Oops because of edev is Null at that time.
So modified the driver registration to after setting drviver data.

- Oops's backtrace.

Backtrace:
[<c067865c>] (state_show) from [<c05222e8>] (dev_attr_show)
[<c05222c0>] (dev_attr_show) from [<c02c66e0>] (sysfs_kf_seq_show)
[<c02c6648>] (sysfs_kf_seq_show) from [<c02c496c>] (kernfs_seq_show)
[<c02c4938>] (kernfs_seq_show) from [<c025e2a0>] (seq_read)
[<c025e11c>] (seq_read) from [<c02c50a0>] (kernfs_fop_read)
[<c02c5064>] (kernfs_fop_read) from [<c0231cac>] (__vfs_read)
[<c0231c5c>] (__vfs_read) from [<c0231ee0>] (vfs_read)
[<c0231e34>] (vfs_read) from [<c0232464>] (ksys_read)
[<c02323f0>] (ksys_read) from [<c02324fc>] (sys_read)
[<c02324e4>] (sys_read) from [<c00091d0>] (__sys_trace_return)

Signed-off-by: bumwoo lee <bw365.lee@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
drivers/extcon/extcon.c