]> git.itanic.dy.fi Git - linux-stable/commit
net: phylink: fix ksettings_set() ethtool call
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Sat, 13 May 2023 21:03:45 +0000 (22:03 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 May 2023 09:31:23 +0000 (10:31 +0100)
commitdf0acdc59b094cdaef19b1c8d83c9721082bab7b
tree26467b10a21bae151a37dec09a53caff53ee0475
parentd1b2777d1467a3aa86d403492cc0411bf429dbe4
net: phylink: fix ksettings_set() ethtool call

While testing a Fiberstore SFP-10G-T module (which uses 10GBASE-R with
rate adaption) in a Clearfog platform (which can't do that) it was
found that the PHYs advertisement was not limited according to the
hosts capabilities when using ethtool to change it.

Fix this by ensuring that we mask the advertisement with the computed
support mask as the very first thing we do.

Fixes: cbc1bb1e4689 ("net: phylink: simplify phy case for ksettings_set method")
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phylink.c