]> git.itanic.dy.fi Git - linux-stable/commit
scsi: pm80xx: Do not call scsi_remove_host() in pm8001_alloc()
authorIgor Pylypiv <ipylypiv@google.com>
Wed, 1 Dec 2021 04:16:27 +0000 (20:16 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 3 Dec 2021 02:40:12 +0000 (21:40 -0500)
commit653926205741add87a6cf452e21950eebc6ac10b
tree1fc8699968b8155213bf17447f34b26bc1c4f398
parent7dc9fb47bc9a95f1cc6c5655341860c5e50f91d4
scsi: pm80xx: Do not call scsi_remove_host() in pm8001_alloc()

Calling scsi_remove_host() before scsi_add_host() results in a crash:

 BUG: kernel NULL pointer dereference, address: 0000000000000108
 RIP: 0010:device_del+0x63/0x440
 Call Trace:
  device_unregister+0x17/0x60
  scsi_remove_host+0xee/0x2a0
  pm8001_pci_probe+0x6ef/0x1b90 [pm80xx]
  local_pci_probe+0x3f/0x90

We cannot call scsi_remove_host() in pm8001_alloc() because scsi_add_host()
has not been called yet at that point in time.

Function call tree:

  pm8001_pci_probe()
  |
  `- pm8001_pci_alloc()
  |  |
  |  `- pm8001_alloc()
  |     |
  |     `- scsi_remove_host()
  |
  `- scsi_add_host()

Link: https://lore.kernel.org/r/20211201041627.1592487-1-ipylypiv@google.com
Fixes: 05c6c029a44d ("scsi: pm80xx: Increase number of supported queues")
Reviewed-by: Vishakha Channapattan <vishakhavc@google.com>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_init.c