]> git.itanic.dy.fi Git - linux-stable/commit
usb: typec: ucsi: Fix for incorrect status data issue
authorHeikki Krogerus <heikki.krogerus@linux.intel.com>
Thu, 21 Jun 2018 13:43:19 +0000 (16:43 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 25 Jun 2018 13:30:12 +0000 (21:30 +0800)
commit68816e16b4789f2d05e77b6dcb77564cf5d6a8d8
tree8c8c8736a5036d6d31cc8bd1df2fd9ebce0cb6f2
parent1f9f9d168ce619608572b01771c47a41b15429e6
usb: typec: ucsi: Fix for incorrect status data issue

According to UCSI Specification, Connector Change Event only
means a change in the Connector Status and Operation Mode
fields of the STATUS data structure. So any other change
should create another event.

Unfortunately on some platforms the firmware acting as PPM
(platform policy manager - usually embedded controller
firmware) still does not report any other status changes if
there is a connector change event. So if the connector power
or data role was changed when a device was plugged to the
connector, the driver does not get any indication about
that. The port will show wrong roles if that happens.

To fix the issue, always checking the data and power role
together with a connector change event.

Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/ucsi/ucsi.c