]> git.itanic.dy.fi Git - linux-stable/commit
sch_cake: avoid possible divide by zero in cake_enqueue()
authorWen Yang <wenyang@linux.alibaba.com>
Thu, 2 Jan 2020 09:21:43 +0000 (17:21 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Jan 2020 00:34:28 +0000 (16:34 -0800)
commit68aab823c223646fab311f8a6581994facee66a0
treeb0ca5b68fbeda17f190305cdae73670591f7887a
parentd8513df2598e5142f8a5c4724f28411936e1dfc7
sch_cake: avoid possible divide by zero in cake_enqueue()

The variables 'window_interval' is u64 and do_div()
truncates it to 32 bits, which means it can test
non-zero and be truncated to zero for division.
The unit of window_interval is nanoseconds,
so its lower 32-bit is relatively easy to exceed.
Fix this issue by using div64_u64() instead.

Fixes: 7298de9cd725 ("sch_cake: Add ingress mode")
Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
Cc: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Cc: Toke Høiland-Jørgensen <toke@redhat.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: cake@lists.bufferbloat.net
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_cake.c