]> git.itanic.dy.fi Git - linux-stable/commit
gpiolib: cdev: Set lineevent_state::irq after IRQ register successfully
authorMeng Li <Meng.Li@windriver.com>
Wed, 21 Sep 2022 03:20:20 +0000 (11:20 +0800)
committerBartosz Golaszewski <brgl@bgdev.pl>
Wed, 21 Sep 2022 07:32:11 +0000 (09:32 +0200)
commit69bef19d6b9700e96285f4b4e28691cda3dcd0d1
tree9a2c14b65f62b1d265239e0b196b40ec50fc268f
parent21a9acc162457402c74c5c1e16471fda6eb090c0
gpiolib: cdev: Set lineevent_state::irq after IRQ register successfully

When running gpio test on nxp-ls1028 platform with below command
gpiomon --num-events=3 --rising-edge gpiochip1 25
There will be a warning trace as below:
Call trace:
free_irq+0x204/0x360
lineevent_free+0x64/0x70
gpio_ioctl+0x598/0x6a0
__arm64_sys_ioctl+0xb4/0x100
invoke_syscall+0x5c/0x130
......
el0t_64_sync+0x1a0/0x1a4
The reason of this issue is that calling request_threaded_irq()
function failed, and then lineevent_free() is invoked to release
the resource. Since the lineevent_state::irq was already set, so
the subsequent invocation of free_irq() would trigger the above
warning call trace. To fix this issue, set the lineevent_state::irq
after the IRQ register successfully.

Fixes: 468242724143 ("gpiolib: cdev: refactor lineevent cleanup into lineevent_free")
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
Reviewed-by: Kent Gibson <warthog618@gmail.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpiolib-cdev.c