]> git.itanic.dy.fi Git - linux-stable/commit
s390: preempt: Fix preempt_count initialization
authorValentin Schneider <valentin.schneider@arm.com>
Wed, 7 Jul 2021 16:33:38 +0000 (17:33 +0100)
committerVasily Gorbik <gor@linux.ibm.com>
Thu, 8 Jul 2021 20:12:18 +0000 (22:12 +0200)
commit6a942f5780545ebd11aca8b3ac4b163397962322
treef0a20802aa79e32712f4b3ca893166a3072ab98b
parent4ee471fe5a5a891ac4fcd45b5457fcb17de694de
s390: preempt: Fix preempt_count initialization

S390's init_idle_preempt_count(p, cpu) doesn't actually let us initialize the
preempt_count of the requested CPU's idle task: it unconditionally writes
to the current CPU's. This clearly conflicts with idle_threads_init(),
which intends to initialize *all* the idle tasks, including their
preempt_count (or their CPU's, if the arch uses a per-CPU preempt_count).

Unfortunately, it seems the way s390 does things doesn't let us initialize
every possible CPU's preempt_count early on, as the pages where this
resides are only allocated when a CPU is brought up and are freed when it
is brought down.

Let the arch-specific code set a CPU's preempt_count when its lowcore is
allocated, and turn init_idle_preempt_count() into an empty stub.

Fixes: f1a0a376ca0c ("sched/core: Initialize the idle task with preemption disabled")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Link: https://lore.kernel.org/r/20210707163338.1623014-1-valentin.schneider@arm.com
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
arch/s390/include/asm/preempt.h
arch/s390/kernel/setup.c
arch/s390/kernel/smp.c