]> git.itanic.dy.fi Git - linux-stable/commit
net/mlx4_core: Fix init_hca fields offset
authorAya Levin <ayal@nvidia.com>
Wed, 18 Nov 2020 08:19:22 +0000 (10:19 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 19 Nov 2020 01:46:20 +0000 (17:46 -0800)
commit6d9c8d15af0ef20a66a0b432cac0d08319920602
treebfb80ce2ddafe292ca580c3cf5d1d3e49f316134
parentf93e8497a9bc6d4b7a0efcb9f54e36f806544a38
net/mlx4_core: Fix init_hca fields offset

Slave function read the following capabilities from the wrong offset:
1. log_mc_entry_sz
2. fs_log_entry_sz
3. log_mc_hash_sz

Fix that by adjusting these capabilities offset to match firmware
layout.

Due to the wrong offset read, the following issues might occur:
1+2. Negative value reported at max_mcast_qp_attach.
3. Driver to init FW with multicast hash size of zero.

Fixes: a40ded604365 ("net/mlx4_core: Add masking for a few queries on HCA caps")
Signed-off-by: Aya Levin <ayal@nvidia.com>
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
Reviewed-by: Eran Ben Elisha <eranbe@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://lore.kernel.org/r/20201118081922.553-1-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx4/fw.c
drivers/net/ethernet/mellanox/mlx4/fw.h