]> git.itanic.dy.fi Git - linux-stable/commit
xfs: fix xfs_ifree() error handling to not leak perag ref
authorBrian Foster <bfoster@redhat.com>
Mon, 30 May 2022 00:56:33 +0000 (10:56 +1000)
committerDave Chinner <david@fromorbit.com>
Mon, 30 May 2022 00:56:33 +0000 (10:56 +1000)
commit6f5097e3367a7c0751e165e4c15bc30511a4ba38
treefd572f54c58f1b428e07b046936f09b3ce772354
parenta54f78def73d847cb060b18c4e4a3d1d26c9ca6d
xfs: fix xfs_ifree() error handling to not leak perag ref

For some reason commit 9a5280b312e2e ("xfs: reorder iunlink remove
operation in xfs_ifree") replaced a jump to the exit path in the
event of an xfs_difree() error with a direct return, which skips
releasing the perag reference acquired at the top of the function.
Restore the original code to drop the reference on error.

Fixes: 9a5280b312e2e ("xfs: reorder iunlink remove operation in xfs_ifree")
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_inode.c