]> git.itanic.dy.fi Git - linux-stable/commit
net/sched: act_mirred: better wording on protection against excessive stack growth
authorDavide Caratti <dcaratti@redhat.com>
Fri, 20 Jan 2023 17:01:39 +0000 (18:01 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 24 Jan 2023 09:30:54 +0000 (10:30 +0100)
commit78dcdffe0418ac8f3f057f26fe71ccf4d8ed851f
tree256b1c17fa58a0715c2ffd34d5b4fbe2f566cc8c
parent5cf6c22b5b7b75caa804c6454932f2f48f7ddb1c
net/sched: act_mirred: better wording on protection against excessive stack growth

with commit e2ca070f89ec ("net: sched: protect against stack overflow in
TC act_mirred"), act_mirred protected itself against excessive stack growth
using per_cpu counter of nested calls to tcf_mirred_act(), and capping it
to MIRRED_RECURSION_LIMIT. However, such protection does not detect
recursion/loops in case the packet is enqueued to the backlog (for example,
when the mirred target device has RPS or skb timestamping enabled). Change
the wording from "recursion" to "nesting" to make it more clear to readers.

CC: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/sched/act_mirred.c