]> git.itanic.dy.fi Git - linux-stable/commit
igb: Fix use-after-free error during reset
authorVinicius Costa Gomes <vinicius.gomes@intel.com>
Fri, 14 May 2021 00:31:04 +0000 (17:31 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 1 Jul 2021 17:53:04 +0000 (10:53 -0700)
commit7b292608db23ccbbfbfa50cdb155d01725d7a52e
treeaaf9e657a3986864c24fe0d29854ff9eb2eefefe
parent56ea7ed103b46970e171eb1c95916f393d64eeff
igb: Fix use-after-free error during reset

Cleans the next descriptor to watch (next_to_watch) when cleaning the
TX ring.

Failure to do so can cause invalid memory accesses. If igb_poll() runs
while the controller is reset this can lead to the driver try to free
a skb that was already freed.

(The crash is harder to reproduce with the igb driver, but the same
potential problem exists as the code is identical to igc)

Fixes: 7cc6fd4c60f2 ("igb: Don't bother clearing Tx buffer_info in igb_clean_tx_ring")
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Reported-by: Erez Geva <erez.geva.ext@siemens.com>
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igb/igb_main.c