]> git.itanic.dy.fi Git - linux-stable/commit
bpf, sockmap: fix leak in bpf_tcp_sendmsg wait for mem path
authorDaniel Borkmann <daniel@iogearbox.net>
Wed, 8 Aug 2018 17:23:14 +0000 (19:23 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 8 Aug 2018 19:06:17 +0000 (12:06 -0700)
commit7c81c71730456845e6212dccbf00098faa66740f
tree22562f2b30e843b45f880f531ac8986253355462
parent5121700b346b6160ccc9411194e3f1f417c340d1
bpf, sockmap: fix leak in bpf_tcp_sendmsg wait for mem path

In bpf_tcp_sendmsg() the sk_alloc_sg() may fail. In the case of
ENOMEM, it may also mean that we've partially filled the scatterlist
entries with pages. Later jumping to sk_stream_wait_memory()
we could further fail with an error for several reasons, however
we miss to call free_start_sg() if the local sk_msg_buff was used.

Fixes: 4f738adba30a ("bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/sockmap.c