]> git.itanic.dy.fi Git - linux-stable/commit
iavf: initialize waitqueues before starting watchdog_task
authorMichal Schmidt <mschmidt@redhat.com>
Thu, 19 Oct 2023 07:13:46 +0000 (09:13 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 20 Oct 2023 10:45:07 +0000 (11:45 +0100)
commit7db3111043885c146e795c199d39c3f9042d97c0
treeb3f5a6e72fbbb2698b5cc1d94536f66e568dceb4
parentf97eee484e71890131f9c563c5cc6d5a69e4308d
iavf: initialize waitqueues before starting watchdog_task

It is not safe to initialize the waitqueues after queueing the
watchdog_task. It will be using them.

The chance of this causing a real problem is very small, because
there will be some sleeping before any of the waitqueues get used.
I got a crash only after inserting an artificial sleep in iavf_probe.

Queue the watchdog_task as the last step in iavf_probe. Add a comment to
prevent repeating the mistake.

Fixes: fe2647ab0c99 ("i40evf: prevent VF close returning before state transitions to DOWN")
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/intel/iavf/iavf_main.c