]> git.itanic.dy.fi Git - linux-stable/commit
drm: Fix drm_fixp2int_round() making it add 0.5
authorArthur Grillo <arthurgrillo@riseup.net>
Sat, 16 Mar 2024 16:25:20 +0000 (13:25 -0300)
committerMelissa Wen <melissa.srw@gmail.com>
Tue, 19 Mar 2024 00:28:28 +0000 (23:28 -0100)
commit807f96abdf14c80f534c78f2d854c2590963345c
tree372aac3d0095d815fe850b9395b4aadb9258ea09
parentf1a785101d50f5844ed29341142e7224b87f705d
drm: Fix drm_fixp2int_round() making it add 0.5

As well noted by Pekka[1], the rounding of drm_fixp2int_round is wrong.
To round a number, you need to add 0.5 to the number and floor that,
drm_fixp2int_round() is adding 0.0000076. Make it add 0.5.

[1]: https://lore.kernel.org/all/20240301135327.22efe0dd.pekka.paalanen@collabora.com/

Fixes: 8b25320887d7 ("drm: Add fixed-point helper to get rounded integer values")
Suggested-by: Pekka Paalanen <pekka.paalanen@collabora.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
Signed-off-by: Arthur Grillo <arthurgrillo@riseup.net>
Signed-off-by: Melissa Wen <melissa.srw@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240316-drm_fixed-v2-1-c1bc2665b5ed@riseup.net
include/drm/drm_fixed.h