]> git.itanic.dy.fi Git - linux-stable/commit
coresight: ultrasoc-smb: Config SMB buffer before register sink
authorJunhao He <hejunhao3@huawei.com>
Tue, 14 Nov 2023 13:33:44 +0000 (21:33 +0800)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Thu, 16 Nov 2023 10:00:12 +0000 (10:00 +0000)
commit830a7f54db102c889a3fe1c0a225f369ac05f07f
tree9d8456afe0bc93638f01a667dadc158a7dcde79a
parentb8411287aef4a994eff0c68f5597910c4194dfe3
coresight: ultrasoc-smb: Config SMB buffer before register sink

The SMB dirver register the enable/disable sysfs interface in function
smb_register_sink(), however the buffer depends on the following
configuration to work well. So it'll be possible for user to access an
unreset one.

Move the config buffer operation to before register_sink().
Ignore the return value, if smb_config_inport() fails. That will
cause the hardwares disable trace path to fail, should not affect
SMB driver remove. So we make smb_remove() return success,

Fixes: 06f5c2926aaa ("drivers/coresight: Add UltraSoc System Memory Buffer driver")
Signed-off-by: Junhao He <hejunhao3@huawei.com>
Reviewed-by: James Clark <james.clark@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/20231114133346.30489-3-hejunhao3@huawei.com
drivers/hwtracing/coresight/ultrasoc-smb.c