]> git.itanic.dy.fi Git - linux-stable/commit
drm/xe/vm: prevent UAF with asid based lookup
authorMatthew Auld <matthew.auld@intel.com>
Fri, 12 Apr 2024 11:31:45 +0000 (12:31 +0100)
committerMatthew Auld <matthew.auld@intel.com>
Wed, 17 Apr 2024 12:38:11 +0000 (13:38 +0100)
commit83967c57320d0d01ae512f10e79213f81e4bf594
treee03f4a9bff8f68fcdbf131b437fe9a93ede3e0de
parent48b1f11c95e8c9ded6516b9e0fd3abddcfc89163
drm/xe/vm: prevent UAF with asid based lookup

The asid is only erased from the xarray when the vm refcount reaches
zero, however this leads to potential UAF since the xe_vm_get() only
works on a vm with refcount != 0. Since the asid is allocated in the vm
create ioctl, rather erase it when closing the vm, prior to dropping the
potential last ref. This should also work when user closes driver fd
without explicit vm destroy.

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/1594
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: <stable@vger.kernel.org> # v6.8+
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240412113144.259426-4-matthew.auld@intel.com
drivers/gpu/drm/xe/xe_vm.c