]> git.itanic.dy.fi Git - linux-stable/commit
riscv: ftrace: Fixup panic by disabling preemption
authorAndy Chiu <andy.chiu@sifive.com>
Thu, 12 Jan 2023 09:05:57 +0000 (04:05 -0500)
committerPalmer Dabbelt <palmer@rivosinc.com>
Wed, 15 Feb 2023 18:58:09 +0000 (10:58 -0800)
commit8547649981e6631328cd64f583667501ae385531
tree327b9f30e2d7c8daaca266e351f69662aa0cb576
parent1b929c02afd37871d5afb9d498426f83432e71c2
riscv: ftrace: Fixup panic by disabling preemption

In RISCV, we must use an AUIPC + JALR pair to encode an immediate,
forming a jump that jumps to an address over 4K. This may cause errors
if we want to enable kernel preemption and remove dependency from
patching code with stop_machine(). For example, if a task was switched
out on auipc. And, if we changed the ftrace function before it was
switched back, then it would jump to an address that has updated 11:0
bits mixing with previous XLEN:12 part.

p: patched area performed by dynamic ftrace
ftrace_prologue:
p|      REG_S   ra, -SZREG(sp)
p|      auipc   ra, 0x? ------------> preempted
...
change ftrace function
...
p|      jalr    -?(ra) <------------- switched back
p|      REG_L   ra, -SZREG(sp)
func:
xxx
ret

Fixes: afc76b8b8011 ("riscv: Using PATCHABLE_FUNCTION_ENTRY instead of MCOUNT")
Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Link: https://lore.kernel.org/r/20230112090603.1295340-2-guoren@kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/Kconfig