]> git.itanic.dy.fi Git - linux-stable/commit
net: fix skb leak in __skb_tstamp_tx()
authorPratyush Yadav <ptyadav@amazon.de>
Mon, 22 May 2023 15:30:20 +0000 (17:30 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 24 May 2023 03:51:43 +0000 (20:51 -0700)
commit8a02fb71d7192ff1a9a47c9d937624966c6e09af
treea05b9753f2da5aca2c4148c16ca95f31545312e8
parentd6c36cbc5e533f48bd89a7b5f339bd82b8b4378a
net: fix skb leak in __skb_tstamp_tx()

Commit 50749f2dd685 ("tcp/udp: Fix memleaks of sk and zerocopy skbs with
TX timestamp.") added a call to skb_orphan_frags_rx() to fix leaks with
zerocopy skbs. But it ended up adding a leak of its own. When
skb_orphan_frags_rx() fails, the function just returns, leaking the skb
it just cloned. Free it before returning.

This bug was discovered and resolved using Coverity Static Analysis
Security Testing (SAST) by Synopsys, Inc.

Fixes: 50749f2dd685 ("tcp/udp: Fix memleaks of sk and zerocopy skbs with TX timestamp.")
Signed-off-by: Pratyush Yadav <ptyadav@amazon.de>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20230522153020.32422-1-ptyadav@amazon.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/skbuff.c