]> git.itanic.dy.fi Git - linux-stable/commit
ASoC: rt5682: Disable jack detection interrupt during suspend
authorMatthias Kaehlcke <mka@chromium.org>
Tue, 16 May 2023 16:46:30 +0000 (16:46 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 17 May 2023 01:48:07 +0000 (10:48 +0900)
commit8b271370e963370703819bd9795a54d658071bed
tree6067ed8060cc6559411a5228bb4c84e3f36d9741
parent75e5fab7db0cecb6e16b22c34608f0b40a4c7cd1
ASoC: rt5682: Disable jack detection interrupt during suspend

The rt5682 driver switches its regmap to cache-only when the
device suspends and back to regular mode on resume. When the
jack detect interrupt fires rt5682_irq() schedules the jack
detect work. This can result in invalid reads from the regmap
in cache-only mode if the work runs before the device has
resumed:

[   56.245502] rt5682 9-001a: ASoC: error at soc_component_read_no_lock on rt5682.9-001a for register: [0x000000f0] -16

Disable the jack detection interrupt during suspend and
re-enable it on resume. The driver already schedules the
jack detection work on resume, so any state change during
suspend is still handled.

This is essentially the same as commit f7d00a9be147 ("SoC:
rt5682s: Disable jack detection interrupt during suspend")
for the rt5682s.

Cc: stable@kernel.org
Signed-off-by: Matthias Kaehlcke <mka@chromium.org
Reviewed-by: Douglas Anderson <dianders@chromium.org
Reviewed-by: Stephen Boyd <swboyd@chromium.org
Link: https://lore.kernel.org/r/20230516164629.1.Ibf79e94b3442eecc0054d2b478779cc512d967fc@changeid
Signed-off-by: Mark Brown <broonie@kernel.org
sound/soc/codecs/rt5682-i2c.c
sound/soc/codecs/rt5682.c
sound/soc/codecs/rt5682.h