]> git.itanic.dy.fi Git - linux-stable/commit
MIPS: KVM: Fix memory leak on VCPU
authorDeng-Cheng Zhu <dengcheng.zhu@imgtec.com>
Tue, 24 Jun 2014 17:31:08 +0000 (10:31 -0700)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 25 Jun 2014 12:17:03 +0000 (14:17 +0200)
commit8c9eb041cf76038eb3b62ee259607eec9b89f48d
treec288fa0bd0adc23df399426d7c199ae1c489364d
parent7cb060a91c0efc5ff94f83c6df3ed705e143cdb9
MIPS: KVM: Fix memory leak on VCPU

kvm_arch_vcpu_free() is called in 2 code paths:

1) kvm_vm_ioctl()
       kvm_vm_ioctl_create_vcpu()
           kvm_arch_vcpu_destroy()
               kvm_arch_vcpu_free()
2) kvm_put_kvm()
       kvm_destroy_vm()
           kvm_arch_destroy_vm()
               kvm_mips_free_vcpus()
                   kvm_arch_vcpu_free()

Neither of the paths handles VCPU free. We need to do it in
kvm_arch_vcpu_free() corresponding to the memory allocation in
kvm_arch_vcpu_create().

Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
Cc: stable@vger.kernel.org
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/mips/kvm/kvm_mips.c