]> git.itanic.dy.fi Git - linux-stable/commit
net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop()
authorFlorian Fainelli <f.fainelli@gmail.com>
Thu, 4 May 2023 23:07:27 +0000 (16:07 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 5 May 2023 09:03:56 +0000 (10:03 +0100)
commit93e0401e0fc0c54b0ac05b687cd135c2ac38187c
tree7179e5741003b7553c0b462da7c2ba67448f648a
parent1e76f42779d6a2e45107b34d79d86a57b8077630
net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop()

The call to phy_stop() races with the later call to phy_disconnect(),
resulting in concurrent phy_suspend() calls being run from different
CPUs. The final call to phy_disconnect() ensures that the PHY is
stopped and suspended, too.

Fixes: c96e731c93ff ("net: bcmgenet: connect and disconnect from the PHY state machine")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/genet/bcmgenet.c