]> git.itanic.dy.fi Git - linux-stable/commit
media: pvrusb2: fix memory leak in pvr_probe
authorDongliang Mu <mudongliangabcd@gmail.com>
Thu, 9 Jun 2022 07:35:28 +0000 (08:35 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 20 Jun 2022 09:30:37 +0000 (10:30 +0100)
commit945a9a8e448b65bec055d37eba58f711b39f66f0
treea2e5b35c020d8bb997c8a69c1a0ed900686fdccf
parent5b9b598453d3ae5fa66d7ab591008373a89b91a0
media: pvrusb2: fix memory leak in pvr_probe

The error handling code in pvr2_hdw_create forgets to unregister the
v4l2 device. When pvr2_hdw_create returns back to pvr2_context_create,
it calls pvr2_context_destroy to destroy context, but mp->hdw is NULL,
which leads to that pvr2_hdw_destroy directly returns.

Fix this by adding v4l2_device_unregister to decrease the refcount of
usb interface.

Reported-by: syzbot+77b432d57c4791183ed4@syzkaller.appspotmail.com
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/usb/pvrusb2/pvrusb2-hdw.c