]> git.itanic.dy.fi Git - linux-stable/commit
ext4: fix bdev write error check failed when mount fs with ro
authorZhang Xiaoxu <zhangxiaoxu5@huawei.com>
Mon, 28 Sep 2020 02:05:56 +0000 (22:05 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Sun, 18 Oct 2020 14:36:59 +0000 (10:36 -0400)
commit9704a322ea67fdb05fc66cf431fdd01c2424bbd9
treef1ae6776ec0a38cef434aa95149173449d92f37f
parentdd0db94f305c9f5dd44d0ecc7bf29944d4867074
ext4: fix bdev write error check failed when mount fs with ro

Consider a situation when a filesystem was uncleanly shutdown and the
orphan list is not empty and a read-only mount is attempted. The orphan
list cleanup during mount will fail with:

ext4_check_bdev_write_error:193: comm mount: Error while async write back metadata

This happens because sbi->s_bdev_wb_err is not initialized when mounting
the filesystem in read only mode and so ext4_check_bdev_write_error()
falsely triggers.

Initialize sbi->s_bdev_wb_err unconditionally to avoid this problem.

Fixes: bc71726c7257 ("ext4: abort the filesystem if failed to async write metadata buffer")
Cc: stable@kernel.org
Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20200928020556.710971-1-zhangxiaoxu5@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/super.c