]> git.itanic.dy.fi Git - linux-stable/commit
Input: iforce - wake up after clearing IFORCE_XMIT_RUNNING flag
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Sun, 28 Aug 2022 03:36:27 +0000 (20:36 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Sun, 28 Aug 2022 03:54:06 +0000 (20:54 -0700)
commit98e01215708b6d416345465c09dce2bd4868c67a
tree602ce740eb109c3d02aef0d6e00a8e1d0ffb4deb
parent80b9ebd3e478cd41526cbf84f80c3e0eb885d1d3
Input: iforce - wake up after clearing IFORCE_XMIT_RUNNING flag

syzbot is reporting hung task at __input_unregister_device() [1], for
iforce_close() waiting at wait_event_interruptible() with dev->mutex held
is blocking input_disconnect_device() from __input_unregister_device().

It seems that the cause is simply that commit c2b27ef672992a20 ("Input:
iforce - wait for command completion when closing the device") forgot to
call wake_up() after clear_bit().

Fix this problem by introducing a helper that calls clear_bit() followed
by wake_up_all().

Reported-by: syzbot <syzbot+deb6abc36aad4008f407@syzkaller.appspotmail.com>
Fixes: c2b27ef672992a20 ("Input: iforce - wait for command completion when closing the device")
Tested-by: syzbot <syzbot+deb6abc36aad4008f407@syzkaller.appspotmail.com>
Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Co-developed-by: Hillf Danton <hdanton@sina.com>
Signed-off-by: Hillf Danton <hdanton@sina.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Link: https://lore.kernel.org/r/887021c3-4f13-40ce-c8b9-aa6e09faa3a7@I-love.SAKURA.ne.jp
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/joystick/iforce/iforce-serio.c
drivers/input/joystick/iforce/iforce-usb.c
drivers/input/joystick/iforce/iforce.h