]> git.itanic.dy.fi Git - linux-stable/commit
platform/x86: alienware-wmi: fix kfree on potentially uninitialized pointer
authorColin Ian King <colin.king@canonical.com>
Sat, 30 Mar 2019 00:17:12 +0000 (00:17 +0000)
committerDarren Hart (VMware) <dvhart@infradead.org>
Tue, 16 Apr 2019 20:18:23 +0000 (13:18 -0700)
commit98e2630284ab741804bd0713e932e725466f2f84
tree9fd859658eb3d28d4352f30c8289d3ea7bafd3b1
parent6cc13c28da5beee0f706db6450e190709700b34a
platform/x86: alienware-wmi: fix kfree on potentially uninitialized pointer

Currently the kfree of output.pointer can be potentially freeing
an uninitalized pointer in the case where out_data is NULL. Fix this
by reworking the case where out_data is not-null to perform the
ACPI status check and also the kfree of outpoint.pointer in one block
and hence ensuring the pointer is only freed when it has been used.

Also replace the if (ptr != NULL) idiom with just if (ptr).

Fixes: ff0e9f26288d ("platform/x86: alienware-wmi: Correct a memory leak")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
drivers/platform/x86/alienware-wmi.c