]> git.itanic.dy.fi Git - linux-stable/commit
HID: wacom: Use ktime_t rather than int when dealing with timestamps
authorJason Gerecke <jason.gerecke@wacom.com>
Thu, 8 Jun 2023 21:38:28 +0000 (14:38 -0700)
committerBenjamin Tissoires <bentiss@kernel.org>
Mon, 26 Jun 2023 14:09:28 +0000 (16:09 +0200)
commit9a6c0e28e215535b2938c61ded54603b4e5814c5
treec64340fadca7b38d39e11a5b69411164ba464b53
parent4c2216728f688da3c4478fec23be9bd820824664
HID: wacom: Use ktime_t rather than int when dealing with timestamps

Code which interacts with timestamps needs to use the ktime_t type
returned by functions like ktime_get. The int type does not offer
enough space to store these values, and attempting to use it is a
recipe for problems. In this particular case, overflows would occur
when calculating/storing timestamps leading to incorrect values being
reported to userspace. In some cases these bad timestamps cause input
handling in userspace to appear hung.

Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/901
Fixes: 17d793f3ed53 ("HID: wacom: insert timestamp to packed Bluetooth (BT) events")
CC: stable@vger.kernel.org
Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Link: https://lore.kernel.org/r/20230608213828.2108-1-jason.gerecke@wacom.com
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
drivers/hid/wacom_wac.c
drivers/hid/wacom_wac.h