]> git.itanic.dy.fi Git - linux-stable/commit
fuse: Don't access pipe->buffers without pipe_lock()
authorAndrey Ryabinin <aryabinin@virtuozzo.com>
Tue, 17 Jul 2018 16:00:33 +0000 (19:00 +0300)
committerMiklos Szeredi <mszeredi@redhat.com>
Thu, 26 Jul 2018 14:13:11 +0000 (16:13 +0200)
commita2477b0e67c52f4364a47c3ad70902bc2a61bd4c
treecb4724a138dccddd5f972b3174d075bf02cf2914
parent63576c13bd17848376c8ba4a98f5d5151140c4ac
fuse: Don't access pipe->buffers without pipe_lock()

fuse_dev_splice_write() reads pipe->buffers to determine the size of
'bufs' array before taking the pipe_lock(). This is not safe as
another thread might change the 'pipe->buffers' between the allocation
and taking the pipe_lock(). So we end up with too small 'bufs' array.

Move the bufs allocations inside pipe_lock()/pipe_unlock() to fix this.

Fixes: dd3bb14f44a6 ("fuse: support splice() writing to fuse device")
Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: <stable@vger.kernel.org> # v2.6.35
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/fuse/dev.c