]> git.itanic.dy.fi Git - linux-stable/commit
nfs: use IS_ROOT not DCACHE_DISCONNECTED
authorJ. Bruce Fields <bfields@redhat.com>
Tue, 15 Oct 2013 21:03:16 +0000 (17:03 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Mon, 28 Oct 2013 23:19:19 +0000 (19:19 -0400)
commita3f432bfd06a4ec3b812e32d3266e0d1ad75d008
tree0e360753066b9dc61df85b2c5234f544ff418527
parent9d3a2260f0f4bd6379b0a0f131c743fff25b0029
nfs: use IS_ROOT not DCACHE_DISCONNECTED

This check was added by Al Viro with
d9e80b7de91db05c1c4d2e5ebbfd70b3b3ba0e0f "nfs d_revalidate() is too
trigger-happy with d_drop()", with the explanation that we don't want to
remove the root of a disconnected tree, which will still be included on
the s_anon list.

But DCACHE_DISCONNECTED does *not* actually identify dentries that are
disconnected from the dentry tree or hashed on s_anon.  IS_ROOT() is the
way to do that.

Also add a comment from Al's commit to remind us why this check is
there.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/dir.c