]> git.itanic.dy.fi Git - linux-stable/commit
powerpc/xmon: Fix disabling tracing while in xmon
authorNaveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Thu, 27 Jun 2019 09:59:40 +0000 (15:29 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 1 Jul 2019 06:26:55 +0000 (16:26 +1000)
commitaaf06665f7ea3ee9f9754e16c1a507a89f1de5b1
treefb1945c13dbcadfdc0b2f36c103e4b011c5023ef
parent6820e565d35084bb9d3a167e990fcb780ccd716f
powerpc/xmon: Fix disabling tracing while in xmon

Commit ed49f7fd6438d ("powerpc/xmon: Disable tracing when entering
xmon") added code to disable recording trace entries while in xmon. The
commit introduced a variable 'tracing_enabled' to record if tracing was
enabled on xmon entry, and used this to conditionally enable tracing
during exit from xmon.

However, we are not checking the value of 'fromipi' variable in
xmon_core() when setting 'tracing_enabled'. Due to this, when secondary
cpus enter xmon, they will see tracing as being disabled already and
tracing won't be re-enabled on exit. Fix the same.

Fixes: ed49f7fd6438d ("powerpc/xmon: Disable tracing when entering xmon")
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/xmon/xmon.c