]> git.itanic.dy.fi Git - linux-stable/commit
drm/rockchip: Fix return type of cdn_dp_connector_mode_valid
authorNathan Huckleberry <nhuck@google.com>
Tue, 13 Sep 2022 20:55:55 +0000 (13:55 -0700)
committerHeiko Stuebner <heiko@sntech.de>
Wed, 14 Sep 2022 08:42:41 +0000 (10:42 +0200)
commitb0b9408f132623dc88e78adb5282f74e4b64bb57
tree6d94f61fb3b91d3a9452d4502977d5790991113c
parent35b513a74eabf09bd718e04fd9e62b09c022807f
drm/rockchip: Fix return type of cdn_dp_connector_mode_valid

The mode_valid field in drm_connector_helper_funcs is expected to be of
type:
enum drm_mode_status (* mode_valid) (struct drm_connector *connector,
     struct drm_display_mode *mode);

The mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

The return type of cdn_dp_connector_mode_valid should be changed from
int to enum drm_mode_status.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20220913205555.155149-1-nhuck@google.com
drivers/gpu/drm/rockchip/cdn-dp-core.c